[feat #140] 채팅 요청 목록 조회 API #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Code Coverage
|
Test Results 25 files 25 suites 14s ⏱️ Results for commit 445c947. |
dudxo
approved these changes
Nov 15, 2024
| .toList(); | ||
|
|
||
| List<LatestChatMessage> latestChatMessages | ||
| = chatMessageQueryRepository.findLatestChatByChatRoomIds(chatRoomIds); |
There was a problem hiding this comment.
�가장 최신의 채팅 메시지 목록을 가져오는 메서드는 분리를 통해 중복을 줄일 수 있을 것 같아요!
There was a problem hiding this comment.
getChatPartner()를 리팩토링해도 괜찮겠네요.
if문에서 바로 return을 던져주고 있기 때문에 else과 else if문을 사용을 줄여도 좋을 것 같아요
private Member getChatPartner(Long memberId, ChatRoom chatRoom) {
if (Objects.equals(chatRoom.getAnswerer().getId(), memberId)) {
return chatRoom.getInquirer();
}
if (Objects.equals(chatRoom.getInquirer().getId(), memberId)) {
return chatRoom.getAnswerer();
}
throw new ValidationException(ChatErrorCode.UNAUTHORIZED_CHAT_ROOM);
}There was a problem hiding this comment.
아니면 더 좋게 바꿀 수 도 있을 것 같아요. Member 객체에서 memberId만 getter통해 가져오기 보다는 Member 객체가 스스로 일을 하도록 하는거죠.
public class Member {
private Long memberId;
....
public boolean isSameId(Long otherId) {
return Objects.equals(otherId);
}
}
private Member getChatPartner(Member member, ChatRoom chatRoom) {
if (member.isSameId(chatRoom.getAnswerer()) {
return chatRoom.getInquirer();
}
if (member.isSameId(chatRoom.getInquirer()))) {
return chatRoom.getAnswerer();
}
throw new ValidationException(ChatErrorCode.UNAUTHORIZED_CHAT_ROOM);
}There was a problem hiding this comment.
넵. 제안주신 부분 다음 PR에 참고해서 반영하겠습니다! 감사합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
요청중상태의 표시 UI가 다름 ->요청대기,수락하기isInquirer,chatStatus필드 추가💫 작업 요약
🔍 중점적으로 리뷰 할 부분